test: update WPT encoding tests and run WPT in subdirectories #27860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we do not implement TextDecoderStream or TextEncoderStream.
For a directory like this:
- wpt
- encoding
- streams
- backpressure.any.js
- api-basics.any.js
Previously we only run `api-basics.any.js`, now we also run
`backpressure.any.js` (and any tests in more deeply nested
directories). This enables us to run more of WPT since not
every module put their tests at the top level directory.
Using `git node wpt encoding`
Since we do not implement TextEncoder.prototype.encodeInto
targos
approved these changes
May 24, 2019
|
@targos |
|
@joyeecheung I'd personally squash both commits |
Trott
approved these changes
May 25, 2019
addaleax
approved these changes
May 26, 2019
Trott
added
the
author ready
danbev
pushed a commit
that referenced
this pull request
May 28, 2019
Since we do not implement TextDecoderStream or TextEncoderStream. PR-URL: #27860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
danbev
pushed a commit
that referenced
this pull request
May 28, 2019
For a directory like this:
- wpt
- encoding
- streams
- backpressure.any.js
- api-basics.any.js
Previously we only run `api-basics.any.js`, now we also run
`backpressure.any.js` (and any tests in more deeply nested
directories). This enables us to run more of WPT since not
every module put their tests at the top level directory.
PR-URL: #27860
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
danbev
pushed a commit
that referenced
this pull request
May 28, 2019
Using `git node wpt encoding` PR-URL: #27860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
danbev
pushed a commit
that referenced
this pull request
May 28, 2019
Since we do not implement TextEncoder.prototype.encodeInto PR-URL: #27860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 28, 2019
Since we do not implement TextDecoderStream or TextEncoderStream. PR-URL: #27860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 28, 2019
For a directory like this:
- wpt
- encoding
- streams
- backpressure.any.js
- api-basics.any.js
Previously we only run `api-basics.any.js`, now we also run
`backpressure.any.js` (and any tests in more deeply nested
directories). This enables us to run more of WPT since not
every module put their tests at the top level directory.
PR-URL: #27860
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 28, 2019
Using `git node wpt encoding` PR-URL: #27860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 28, 2019
Since we do not implement TextEncoder.prototype.encodeInto PR-URL: #27860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
AtticusYang
reviewed
Jul 26, 2019
| let { read, written } = new TextEncoder().encodeInto("", view); | ||
| assert_equals(read, 0); | ||
| assert_equals(written, 0); | ||
| new MessageChannel().port1.postMessage(buffer, [buffer]); |
There was a problem hiding this comment.
I try to finish the feature encodeInto, after I finished I tested it with the test cases, but meet the failure as followed
[FAILURE] encodeInto() and a detached output buffer
MessageChannel is not defined
ReferenceError: MessageChannel is not defined
at Test. (node/test/fixtures/wpt/encoding/encodeInto.any.js:142:3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: expect wpt/encoding/streams to fail
Since we do not implement TextDecoderStream or TextEncoderStream.
test: run WPT in subdirectories
For a directory like this:
Previously we only run
api-basics.any.js, now we also runbackpressure.any.js(and any tests in more deeply nesteddirectories). This enables us to run more of WPT since not
every module put their tests at the top level directory.
test: update wpt/encoding to 7287608f90
Using
git node wpt encodingtest: expect wpt/encoding/encodeInto.any.js to fail
Since we do not implement TextEncoder.prototype.encodeInto
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes